diff options
| author |   mkanat%kerio.com <> | 2005-04-05 04:52:03 +0000 |
|---|---|---|
| committer | mkanat%kerio.com <> | 2005-04-05 04:52:03 +0000 |
| commit | f5f31fc070588c2075dd13a0fbabe8117e3aad76 (patch) | |
| tree | 4a3bb48995143c84fcb8f222b420814e1c6e8eaf /editclassifications.cgi | |
| parent | Bug 287483: Sanitycheck screams about "Bad value 0 found in components.initia... (diff) | |
| download | bugzilla-f5f31fc070588c2075dd13a0fbabe8117e3aad76.tar.gz bugzilla-f5f31fc070588c2075dd13a0fbabe8117e3aad76.tar.bz2 bugzilla-f5f31fc070588c2075dd13a0fbabe8117e3aad76.zip | |
Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk
Diffstat (limited to 'editclassifications.cgi')
| -rwxr-xr-x | editclassifications.cgi | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/editclassifications.cgi b/editclassifications.cgi index 9dad9ae37..5f31c50a8 100755 --- a/editclassifications.cgi +++ b/editclassifications.cgi @@ -374,9 +374,11 @@ if ($action eq 'reclassify') { products.name, classifications.name, classifications.id > 1 as unknown - FROM products,classifications - WHERE classifications.id=products.classification_id - ORDER BY unknown, products.name, classifications.name"); + FROM products + INNER JOIN classifications + ON classifications.id = products.classification_id + ORDER BY unknown, products.name, + classifications.name"); $sth->execute(); while ( my ($clid, $name, $clname) = $sth->fetchrow_array() ) { if ($clid == $classification_id) { |