From f5f31fc070588c2075dd13a0fbabe8117e3aad76 Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Tue, 5 Apr 2005 04:52:03 +0000 Subject: Bug 286235: Implicit joins should be replaced by explicit joins - installment A Patch By Tomas Kopal r=joel, a=myk --- editclassifications.cgi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'editclassifications.cgi') diff --git a/editclassifications.cgi b/editclassifications.cgi index 9dad9ae37..5f31c50a8 100755 --- a/editclassifications.cgi +++ b/editclassifications.cgi @@ -374,9 +374,11 @@ if ($action eq 'reclassify') { products.name, classifications.name, classifications.id > 1 as unknown - FROM products,classifications - WHERE classifications.id=products.classification_id - ORDER BY unknown, products.name, classifications.name"); + FROM products + INNER JOIN classifications + ON classifications.id = products.classification_id + ORDER BY unknown, products.name, + classifications.name"); $sth->execute(); while ( my ($clid, $name, $clname) = $sth->fetchrow_array() ) { if ($clid == $classification_id) { -- cgit v1.2.3-65-gdbad