diff options
| author |   Tom Tromey <tom@tromey.com> | 2018-08-29 23:03:09 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-09-13 16:22:34 -0600 |
| commit | 803c08d083556154cd4d27368e58b359e9de8b93 (patch) | |
| tree | 900369c589d11a5926ca59fe244987389692a526 /gdb/compile | |
| parent | Remove cleanup from procfs.c (diff) | |
| download | binutils-gdb-803c08d083556154cd4d27368e58b359e9de8b93.tar.gz binutils-gdb-803c08d083556154cd4d27368e58b359e9de8b93.tar.bz2 binutils-gdb-803c08d083556154cd4d27368e58b359e9de8b93.zip | |
Return std::string from gdb_bfd_errmsg
This changes gdb_bfd_errmsg to return a std::string, removing a
cleanup. This approach may be slightly less efficient than the
previous code, but I don't believe this is very important in this
situation.
gdb/ChangeLog
2018-09-13 Tom Tromey <tom@tromey.com>
* utils.h (gdb_bfd_errmsg): Return std::string.
* exec.c (exec_file_attach): Update.
* compile/compile-object-load.c (compile_object_load): Update.
* utils.c (gdb_bfd_errmsg): Return std::string.
Diffstat (limited to 'gdb/compile')
| -rw-r--r-- | gdb/compile/compile-object-load.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c index 873750b9440..40053d281a1 100644 --- a/gdb/compile/compile-object-load.c +++ b/gdb/compile/compile-object-load.c @@ -638,7 +638,8 @@ compile_object_load (const compile_file_names &file_names, if (!bfd_check_format_matches (abfd.get (), bfd_object, &matching)) error (_("\"%s\": not in loadable format: %s"), - filename.get (), gdb_bfd_errmsg (bfd_get_error (), matching)); + filename.get (), + gdb_bfd_errmsg (bfd_get_error (), matching).c_str ()); if ((bfd_get_file_flags (abfd.get ()) & (EXEC_P | DYNAMIC)) != 0) error (_("\"%s\": not in object format."), filename.get ()); |