don't block installation for kernels >= 2.6.10 but don't install slamr module (#75656)

5 files changed, 36 insertions, 23 deletions

diff --git a/net-dialup/slmodem/ChangeLog b/net-dialup/slmodem/ChangeLog
index 624ef12287dd..33cbedca883f 100644
--- a/net-dialup/slmodem/ChangeLog
+++ b/net-dialup/slmodem/ChangeLog
@@ -1,12 +1,12 @@
 # ChangeLog for net-dialup/slmodem
 # Copyright 2000-2004 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/ChangeLog,v 1.33 2004/12/29 21:54:06 mrness Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/ChangeLog,v 1.34 2004/12/29 22:38:21 mrness Exp $
 
 *slmodem-2.9.10-r3 (29 Dec 2004)
 
-  29 Dec 2004; Alin Nastac <mrness@gentoo.org> slmodem-2.9.10-r1.ebuild,
-  slmodem-2.9.10-r2.ebuild, +slmodem-2.9.10-r3.ebuild:
-  Block installation for kernel versions >= 2.6.10 (#75656). Rewrite ebuild
+  29 Dec 2004; Alin Nastac <mrness@gentoo.org>
+  +files/slmodem-2.9.10-fix-for-2.6.10.patch, +slmodem-2.9.10-r3.ebuild:
+  Don't install slamr for kernel versions >= 2.6.10 (#75656). Rewrite ebuild
   using linux-mod eclass. Create /dev/ppp device at install time (#75913).
 
   29 Dec 2004; Ciaran McCreesh <ciaranm@gentoo.org> :
diff --git a/net-dialup/slmodem/files/slmodem-2.9.10-fix-for-2.6.10.patch b/net-dialup/slmodem/files/slmodem-2.9.10-fix-for-2.6.10.patch
new file mode 100644
index 000000000000..d2035b6d2fef
--- /dev/null
+++ b/net-dialup/slmodem/files/slmodem-2.9.10-fix-for-2.6.10.patch
@@ -0,0 +1,15 @@
+From Linux 2.6.10 onwards, pci_register_driver returns 0 on success and negative on failure
+
+- Daniel Drake <dsd@gentoo.org>
+
+--- slmodem-2.9.10/drivers/amrmo_init.c.orig	2004-12-25 23:53:51.345258848 +0000
++++ slmodem-2.9.10/drivers/amrmo_init.c	2004-12-25 23:54:33.528845968 +0000
+@@ -740,7 +740,7 @@
+ 	}
+ #endif
+ 
+-	if (!pci_register_driver(&amrmo_pci_driver)) {
++	if (pci_register_driver(&amrmo_pci_driver) < 0) {
+ 		pci_unregister_driver(&amrmo_pci_driver);
+ #ifndef OLD_KERNEL
+ 		class_simple_destroy(amrmo_class);
diff --git a/net-dialup/slmodem/slmodem-2.9.10-r1.ebuild b/net-dialup/slmodem/slmodem-2.9.10-r1.ebuild
index be99129d5533..ff6a7d6068ac 100644
--- a/net-dialup/slmodem/slmodem-2.9.10-r1.ebuild
+++ b/net-dialup/slmodem/slmodem-2.9.10-r1.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2004 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/slmodem-2.9.10-r1.ebuild,v 1.4 2004/12/29 21:54:06 mrness Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/slmodem-2.9.10-r1.ebuild,v 1.5 2004/12/29 22:38:21 mrness Exp $
 
 inherit kernel-mod eutils
 
@@ -21,10 +21,6 @@ RDEPEND="virtual/libc
 	alsa? ( media-libs/alsa-lib )"
 
 pkg_setup() {
-	if [ "${KV_MAJOR}" -eq 2 -a "${KV_MINOR}" -eq 6 -a "${KV_PATCH}" -ge 10 ]; then
-		eerror "This package isn't compatible with kernel versions >= 2.6.10!"
-		die "unsupported kernel version"
-	fi
 	kernel-mod_check_modules_supported
 }
 
diff --git a/net-dialup/slmodem/slmodem-2.9.10-r2.ebuild b/net-dialup/slmodem/slmodem-2.9.10-r2.ebuild
index 3e2c7e92f132..4e61417728a2 100644
--- a/net-dialup/slmodem/slmodem-2.9.10-r2.ebuild
+++ b/net-dialup/slmodem/slmodem-2.9.10-r2.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2004 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/slmodem-2.9.10-r2.ebuild,v 1.4 2004/12/29 21:54:06 mrness Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/slmodem-2.9.10-r2.ebuild,v 1.5 2004/12/29 22:38:21 mrness Exp $
 
 inherit eutils linux-info
 
@@ -21,10 +21,6 @@ RDEPEND="virtual/libc
 	alsa? ( media-libs/alsa-lib )"
 
 pkg_setup() {
-	if kernel_is ge 2 6 10; then
-		eerror "This package isn't compatible with kernel versions >= 2.6.10!"
-		die "unsupported kernel version"
-	fi
 	check_modules_supported
 }
 
diff --git a/net-dialup/slmodem/slmodem-2.9.10-r3.ebuild b/net-dialup/slmodem/slmodem-2.9.10-r3.ebuild
index cbfba58d4add..5d5e0b57376b 100644
--- a/net-dialup/slmodem/slmodem-2.9.10-r3.ebuild
+++ b/net-dialup/slmodem/slmodem-2.9.10-r3.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2004 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/slmodem-2.9.10-r3.ebuild,v 1.1 2004/12/29 21:54:06 mrness Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-dialup/slmodem/slmodem-2.9.10-r3.ebuild,v 1.2 2004/12/29 22:38:21 mrness Exp $
 
 inherit eutils linux-mod
 
@@ -21,10 +21,15 @@ RDEPEND="virtual/libc
 	alsa? ( media-libs/alsa-lib )"
 
 pkg_setup() {
+	MODULE_NAMES=""
 	if kernel_is ge 2 6 10; then
-		eerror "This package isn't compatible with kernel versions >= 2.6.10!"
-		die "unsupported kernel version"
+		ewarn "slamr isn't compatible with kernel versions >= 2.6.10!"
+		ewarn "It will not be installed"
+	else
+		MODULE_NAMES="slamr(extra:${S}/drivers)"
 	fi
+	useq usb && MODULE_NAMES="${MODULE_NAMES} slusb(extra:${S}/drivers)"
+	BUILD_TARGETS="all"
 
 	local CONFIG_CHECK=""
 	if useq alsa; then
@@ -34,22 +39,22 @@ pkg_setup() {
 		CONFIG_CHECK="${CONFIG_CHECK} USB"
 	fi
 
-	MODULE_NAMES="slamr(extra:${S}/drivers)"
-	useq usb && MODULE_NAMES="${MODULE_NAMES} slusb(extra:${S}/drivers)"
-	BUILD_TARGETS="all"
-
 	linux-mod_pkg_setup
 }
 
 src_unpack() {
 	unpack ${A}
 	cd ${S}
-	epatch ${FILESDIR}/${P}-usb_endpoint_halted-gentoo.patch || die "failed to apply patch for fixing usb_endpoint"
+	epatch ${FILESDIR}/${P}-usb_endpoint_halted-gentoo.patch || die "failed to apply fix for usb_endpoint"
 
 	# http://marc.theaimsgroup.com/?l=gentoo-dev&m=109672618708314&w=2
 	if kernel_is ge 2 6 6; then
 		sed -i 's:SUBDIRS=:M=:g' drivers/Makefile
 	fi
+
+	if kernel_is ge 2 6 10; then
+		epatch ${FILESDIR}/${P}-fix-for-2.6.10.patch || die "failed to apply fix for kernels >= 2.6.10"
+	fi
 }
 
 src_compile() {
@@ -100,7 +105,8 @@ src_install() {
 	#Create device nodes, add module aliases and install hotplug script
 	make -C drivers DESTDIR=${D} KERNEL_DIR="${ROOT}/usr/src/linux" install-devices
 	insinto /etc/modules.d/; insopts -m0644; newins ${FILESDIR}/${PN}-2.9.modules ${PN}
-	insinto /etc/hotplug/usb; insopts -m0755; newins ${FILESDIR}/slusb.hotplug slusb
+	useq usb &&
+		( insinto /etc/hotplug/usb; insopts -m0755; newins ${FILESDIR}/slusb.hotplug slusb )
 
 	dodir /etc/hotplug/blacklist.d
 	echo -e "slusb\nslamr\nsnd-intel8x0m" >> ${D}/etc/hotplug/blacklist.d/55-${PN}