Some QA noted by c1pher

(Portage version: 2.2_rc97/cvs/Linux x86_64)

3 files changed, 16 insertions, 12 deletions

diff --git a/app-misc/splitvt/ChangeLog b/app-misc/splitvt/ChangeLog
index 30457f4527c1..74e2bc5c8a4f 100644
--- a/app-misc/splitvt/ChangeLog
+++ b/app-misc/splitvt/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for app-misc/splitvt
 # Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/ChangeLog,v 1.28 2010/10/23 22:34:45 c1pher Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/ChangeLog,v 1.29 2010/10/24 08:24:43 jlec Exp $
+
+  24 Oct 2010; Justin Lecher <jlec@gentoo.org> splitvt-1.6.6-r1.ebuild,
+  splitvt-1.6.6-r2.ebuild:
+  Some QA noted by c1pher
 
   23 Oct 2010; Dane Smith <c1pher@gentoo.org> splitvt-1.6.6-r2.ebuild:
   Stable x86 wrt bug 342143.
diff --git a/app-misc/splitvt/splitvt-1.6.6-r1.ebuild b/app-misc/splitvt/splitvt-1.6.6-r1.ebuild
index ae713ac16f50..0dba78b646c2 100644
--- a/app-misc/splitvt/splitvt-1.6.6-r1.ebuild
+++ b/app-misc/splitvt/splitvt-1.6.6-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2008 Gentoo Foundation
+# Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r1.ebuild,v 1.6 2008/03/29 13:29:04 coldwind Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r1.ebuild,v 1.7 2010/10/24 08:24:43 jlec Exp $
 
 inherit eutils toolchain-funcs
 
@@ -24,13 +24,13 @@ src_unpack() {
 	cd "${S}"
 	epatch "${WORKDIR}"/${MY_P}-${DEB_PL}.diff
 	sed -i -e "s:/usr/local/bin:${D}/usr/bin:g" \
-		-e "s:/usr/local/man/:${D}/usr/share/man/:g" config.c
+		-e "s:/usr/local/man/:${D}/usr/share/man/:g" config.c || die
 }
 
 src_compile() {
 	# upstream has their own weirdo configure script...
 	./configure || die "configure failed"
-	sed -i -e "s:-O2:${CFLAGS}:" -e "s:^CC = gcc:CC = $(tc-getCC):" Makefile
+	sed -i -e "s:-O2:${CFLAGS}:" -e "s:^CC = gcc:CC = $(tc-getCC):" Makefile || die
 	emake || die "emake failed"
 }
 
@@ -38,6 +38,6 @@ src_install() {
 	dodir /usr/bin /usr/share/man/man1/
 	make install || die "make install failed"
 	fperms 755 /usr/bin/xsplitvt
-	dodoc ANNOUNCE BLURB CHANGES NOTES README TODO
-	doman splitvt.1
+	dodoc ANNOUNCE BLURB CHANGES NOTES README TODO || die
+	doman splitvt.1 || die
 }
diff --git a/app-misc/splitvt/splitvt-1.6.6-r2.ebuild b/app-misc/splitvt/splitvt-1.6.6-r2.ebuild
index b20a8ef8fc48..757febd94780 100644
--- a/app-misc/splitvt/splitvt-1.6.6-r2.ebuild
+++ b/app-misc/splitvt/splitvt-1.6.6-r2.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r2.ebuild,v 1.3 2010/10/23 22:34:45 c1pher Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r2.ebuild,v 1.4 2010/10/24 08:24:43 jlec Exp $
 
 EAPI="3"
 
@@ -24,18 +24,18 @@ DEPEND=">=sys-libs/ncurses-5.2"
 RDEPEND="${DEPEND}"
 
 src_prepare() {
-	epatch "${WORKDIR}"/${MY_P}-${DEB_PL}.diff
-	epatch "${FILESDIR}"/${PV}-ldflags.patch
+	epatch \
+		"${WORKDIR}"/${MY_P}-${DEB_PL}.diff \
+		"${FILESDIR}"/${PV}-ldflags.patch
 	sed -i \
 		-e "s:/usr/local/bin:${D}/usr/bin:g" \
 		-e "s:/usr/local/man/:${D}/usr/share/man/:g" config.c || die
 }
 
-src_compile() {
+src_configure() {
 	# upstream has their own weirdo configure script...
 	./configure || die "configure failed"
 	sed -i -e "s:-O2:${CFLAGS}:" -e "s:^CC = gcc:CC = $(tc-getCC):" Makefile || die
-	emake || die "emake failed"
 }
 
 src_install() {