MissingEAPIBlankLine: new check for missing blank after EAPI

Resolves: https://github.com/pkgcore/pkgcheck/issues/570
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

25 files changed, 29 insertions, 0 deletions

diff --git a/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-0.ebuild b/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-0.ebuild
index c93c92cd..304308b5 100644
--- a/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-0.ebuild
+++ b/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild using banned EAPI command"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/BadCommandsCheck/DeprecatedEapiCommand/DeprecatedEapiCommand-0.ebuild b/testdata/repos/standalone/BadCommandsCheck/DeprecatedEapiCommand/DeprecatedEapiCommand-0.ebuild
index 49182b4c..1ef4813e 100644
--- a/testdata/repos/standalone/BadCommandsCheck/DeprecatedEapiCommand/DeprecatedEapiCommand-0.ebuild
+++ b/testdata/repos/standalone/BadCommandsCheck/DeprecatedEapiCommand/DeprecatedEapiCommand-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=6
+
 DESCRIPTION="Ebuild using deprecated EAPI command"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/DependencyCheck/BadDependency/BadDependency-0.ebuild b/testdata/repos/standalone/DependencyCheck/BadDependency/BadDependency-0.ebuild
index 6507af33..4fcffaa8 100644
--- a/testdata/repos/standalone/DependencyCheck/BadDependency/BadDependency-0.ebuild
+++ b/testdata/repos/standalone/DependencyCheck/BadDependency/BadDependency-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with bad dependencies"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/DependencyCheck/InvalidBdepend/InvalidBdepend-0.ebuild b/testdata/repos/standalone/DependencyCheck/InvalidBdepend/InvalidBdepend-0.ebuild
index d5050239..71cdda2d 100644
--- a/testdata/repos/standalone/DependencyCheck/InvalidBdepend/InvalidBdepend-0.ebuild
+++ b/testdata/repos/standalone/DependencyCheck/InvalidBdepend/InvalidBdepend-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with invalid BDEPEND"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/DependencyCheck/InvalidDepend/InvalidDepend-0.ebuild b/testdata/repos/standalone/DependencyCheck/InvalidDepend/InvalidDepend-0.ebuild
index a790cde4..d25a1168 100644
--- a/testdata/repos/standalone/DependencyCheck/InvalidDepend/InvalidDepend-0.ebuild
+++ b/testdata/repos/standalone/DependencyCheck/InvalidDepend/InvalidDepend-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with invalid DEPEND"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/DependencyCheck/InvalidPdepend/InvalidPdepend-0.ebuild b/testdata/repos/standalone/DependencyCheck/InvalidPdepend/InvalidPdepend-0.ebuild
index 2a5ece5c..e9c51202 100644
--- a/testdata/repos/standalone/DependencyCheck/InvalidPdepend/InvalidPdepend-0.ebuild
+++ b/testdata/repos/standalone/DependencyCheck/InvalidPdepend/InvalidPdepend-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with invalid PDEPEND"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/DependencyCheck/InvalidRdepend/InvalidRdepend-0.ebuild b/testdata/repos/standalone/DependencyCheck/InvalidRdepend/InvalidRdepend-0.ebuild
index 09d3ea1c..4c876488 100644
--- a/testdata/repos/standalone/DependencyCheck/InvalidRdepend/InvalidRdepend-0.ebuild
+++ b/testdata/repos/standalone/DependencyCheck/InvalidRdepend/InvalidRdepend-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with invalid RDEPEND"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/DependencyCheck/MissingUseDepDefault/MissingUseDepDefault-0.ebuild b/testdata/repos/standalone/DependencyCheck/MissingUseDepDefault/MissingUseDepDefault-0.ebuild
index 0272b643..53992988 100644
--- a/testdata/repos/standalone/DependencyCheck/MissingUseDepDefault/MissingUseDepDefault-0.ebuild
+++ b/testdata/repos/standalone/DependencyCheck/MissingUseDepDefault/MissingUseDepDefault-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild missing USE dependency default"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/EapiCheck/BannedEapi/BannedEapi-0.ebuild b/testdata/repos/standalone/EapiCheck/BannedEapi/BannedEapi-0.ebuild
index 086ba8fc..04dbdbd8 100644
--- a/testdata/repos/standalone/EapiCheck/BannedEapi/BannedEapi-0.ebuild
+++ b/testdata/repos/standalone/EapiCheck/BannedEapi/BannedEapi-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=1
+
 DESCRIPTION="Ebuild using banned EAPI"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/EapiCheck/DeprecatedEapi/DeprecatedEapi-0.ebuild b/testdata/repos/standalone/EapiCheck/DeprecatedEapi/DeprecatedEapi-0.ebuild
index 8efd64a6..c05b58ea 100644
--- a/testdata/repos/standalone/EapiCheck/DeprecatedEapi/DeprecatedEapi-0.ebuild
+++ b/testdata/repos/standalone/EapiCheck/DeprecatedEapi/DeprecatedEapi-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=5
+
 DESCRIPTION="Ebuild using deprecated EAPI"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/EbuildUnquotedVariable-0.ebuild b/testdata/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/EbuildUnquotedVariable-0.ebuild
index 30ff4887..4a475d71 100644
--- a/testdata/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/EbuildUnquotedVariable-0.ebuild
+++ b/testdata/repos/standalone/EbuildUnquotedVariablesCheck/EbuildUnquotedVariable/EbuildUnquotedVariable-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=8
+
 DESCRIPTION="Ebuild with variables that must be quoted"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/InsintoCheck/DeprecatedInsinto/DeprecatedInsinto-1.ebuild b/testdata/repos/standalone/InsintoCheck/DeprecatedInsinto/DeprecatedInsinto-1.ebuild
index 7a577866..2967624d 100644
--- a/testdata/repos/standalone/InsintoCheck/DeprecatedInsinto/DeprecatedInsinto-1.ebuild
+++ b/testdata/repos/standalone/InsintoCheck/DeprecatedInsinto/DeprecatedInsinto-1.ebuild
@@ -1,4 +1,5 @@
 EAPI=4
+
 DESCRIPTION="Ebuild with deprecated insinto usage"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/IuseCheck/InvalidUseFlags/InvalidUseFlags-4.ebuild b/testdata/repos/standalone/IuseCheck/InvalidUseFlags/InvalidUseFlags-4.ebuild
index c8360cc0..4cda2928 100644
--- a/testdata/repos/standalone/IuseCheck/InvalidUseFlags/InvalidUseFlags-4.ebuild
+++ b/testdata/repos/standalone/IuseCheck/InvalidUseFlags/InvalidUseFlags-4.ebuild
@@ -1,4 +1,5 @@
 EAPI=4
+
 DESCRIPTION="Ebuild with invalid USE flags"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/IuseCheck/UnknownUseFlags/UnknownUseFlags-0.ebuild b/testdata/repos/standalone/IuseCheck/UnknownUseFlags/UnknownUseFlags-0.ebuild
index d42b40ed..9fb834ca 100644
--- a/testdata/repos/standalone/IuseCheck/UnknownUseFlags/UnknownUseFlags-0.ebuild
+++ b/testdata/repos/standalone/IuseCheck/UnknownUseFlags/UnknownUseFlags-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=4
+
 DESCRIPTION="Ebuild with unknown USE flags"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/MissingSlotDepCheck/MissingSlotDep/MissingSlotDep-0.ebuild b/testdata/repos/standalone/MissingSlotDepCheck/MissingSlotDep/MissingSlotDep-0.ebuild
index 2394a37f..4a4a4d40 100644
--- a/testdata/repos/standalone/MissingSlotDepCheck/MissingSlotDep/MissingSlotDep-0.ebuild
+++ b/testdata/repos/standalone/MissingSlotDepCheck/MissingSlotDep/MissingSlotDep-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with dependency missing a slot dep"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/ReadonlyVariableCheck/ReadonlyVariable/ReadonlyVariable-0.ebuild b/testdata/repos/standalone/ReadonlyVariableCheck/ReadonlyVariable/ReadonlyVariable-0.ebuild
index 5320e4da..809752ce 100644
--- a/testdata/repos/standalone/ReadonlyVariableCheck/ReadonlyVariable/ReadonlyVariable-0.ebuild
+++ b/testdata/repos/standalone/ReadonlyVariableCheck/ReadonlyVariable/ReadonlyVariable-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 PV="5"
 DESCRIPTION="Ebuild that assigns read-only variable in global scope"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
diff --git a/testdata/repos/standalone/RedundantDodirCheck/RedundantDodir/RedundantDodir-0.ebuild b/testdata/repos/standalone/RedundantDodirCheck/RedundantDodir/RedundantDodir-0.ebuild
index 19069813..bcf00a6b 100644
--- a/testdata/repos/standalone/RedundantDodirCheck/RedundantDodir/RedundantDodir-0.ebuild
+++ b/testdata/repos/standalone/RedundantDodirCheck/RedundantDodir/RedundantDodir-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with redundant dodir calls"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/RequiredUseCheck/RequiredUseDefaults/RequiredUseDefaults-0.ebuild b/testdata/repos/standalone/RequiredUseCheck/RequiredUseDefaults/RequiredUseDefaults-0.ebuild
index 27879434..31494b50 100644
--- a/testdata/repos/standalone/RequiredUseCheck/RequiredUseDefaults/RequiredUseDefaults-0.ebuild
+++ b/testdata/repos/standalone/RequiredUseCheck/RequiredUseDefaults/RequiredUseDefaults-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=4
+
 DESCRIPTION="Ebuild with REQUIRED_USE failing by default"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/RequiredUseCheck/UnstatedIuse/UnstatedIuse-0.ebuild b/testdata/repos/standalone/RequiredUseCheck/UnstatedIuse/UnstatedIuse-0.ebuild
index 6cb3821e..2b407f8b 100644
--- a/testdata/repos/standalone/RequiredUseCheck/UnstatedIuse/UnstatedIuse-0.ebuild
+++ b/testdata/repos/standalone/RequiredUseCheck/UnstatedIuse/UnstatedIuse-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=4
+
 DESCRIPTION="Ebuild with unstated USE flag in REQUIRED_USE"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-0.ebuild b/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-0.ebuild
index a4a7c8a2..d0fce630 100644
--- a/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-0.ebuild
+++ b/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with reundant rename in SRC_URI"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SRC_URI="https://github.com/pkgcore/pkgcheck/${P}.tar.gz -> ${P}.tar.gz"
diff --git a/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-1.ebuild b/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-1.ebuild
index 7ba49077..7ee2f8cd 100644
--- a/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-1.ebuild
+++ b/testdata/repos/standalone/SrcUriCheck/RedundantUriRename/RedundantUriRename-1.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild with reundant rename in SRC_URI"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SRC_URI="mirror://used/pkgcore/pkgcheck/${P}.tar.gz -> ${P}.tar.gz"
diff --git a/testdata/repos/standalone/SrcUriCheck/TarballAvailable/TarballAvailable-0.ebuild b/testdata/repos/standalone/SrcUriCheck/TarballAvailable/TarballAvailable-0.ebuild
index e5ea35a1..93e37de2 100644
--- a/testdata/repos/standalone/SrcUriCheck/TarballAvailable/TarballAvailable-0.ebuild
+++ b/testdata/repos/standalone/SrcUriCheck/TarballAvailable/TarballAvailable-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=2
+
 DESCRIPTION="Ebuild with SRC_URI using .zip archive when .tar* is available"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SRC_URI="
diff --git a/testdata/repos/standalone/VariableScopeCheck/EbuildVariableScope/EbuildVariableScope-0.ebuild b/testdata/repos/standalone/VariableScopeCheck/EbuildVariableScope/EbuildVariableScope-0.ebuild
index 6020854c..28cc609e 100644
--- a/testdata/repos/standalone/VariableScopeCheck/EbuildVariableScope/EbuildVariableScope-0.ebuild
+++ b/testdata/repos/standalone/VariableScopeCheck/EbuildVariableScope/EbuildVariableScope-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild using a variable outside its defined scope"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/WhitespaceCheck/BadWhitespaceCharacter/BadWhitespaceCharacter-0.ebuild b/testdata/repos/standalone/WhitespaceCheck/BadWhitespaceCharacter/BadWhitespaceCharacter-0.ebuild
index 84641c86..d245eef2 100644
--- a/testdata/repos/standalone/WhitespaceCheck/BadWhitespaceCharacter/BadWhitespaceCharacter-0.ebuild
+++ b/testdata/repos/standalone/WhitespaceCheck/BadWhitespaceCharacter/BadWhitespaceCharacter-0.ebuild
@@ -1,4 +1,5 @@
 EAPI=7
+
 DESCRIPTION="Ebuild uses bad whitespace character"
 HOMEPAGE="https://github.com/pkgcore/pkgcheck"
 SLOT="0"
diff --git a/testdata/repos/standalone/WhitespaceCheck/MissingEAPIBlankLine/MissingEAPIBlankLine-0.ebuild b/testdata/repos/standalone/WhitespaceCheck/MissingEAPIBlankLine/MissingEAPIBlankLine-0.ebuild
new file mode 100644
index 00000000..fc5a6781
--- /dev/null
+++ b/testdata/repos/standalone/WhitespaceCheck/MissingEAPIBlankLine/MissingEAPIBlankLine-0.ebuild
@@ -0,0 +1,5 @@
+EAPI=7
+DESCRIPTION="Ebuild is missing blank line after EAPI"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+SLOT="0"
+LICENSE="BSD"