aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjocuri%softhome.net <>2004-10-21 03:58:59 +0000
committerjocuri%softhome.net <>2004-10-21 03:58:59 +0000
commit5d084582ef240376f7f8a6a35fd94a1bf7b42c2b (patch)
tree91bf0165e7b20dee8a0c0f25a8cf893c261f301e
parentFix for bug 265303: updates RDF content type to new standard application/rdf+... (diff)
downloadbugzilla-5d084582ef240376f7f8a6a35fd94a1bf7b42c2b.tar.gz
bugzilla-5d084582ef240376f7f8a6a35fd94a1bf7b42c2b.tar.bz2
bugzilla-5d084582ef240376f7f8a6a35fd94a1bf7b42c2b.zip
Patch for bug 232155: Remove uninitialized value warning from Pperl's Cookie.pm and unify code by removing redundancy; patch by Christian Reis <kiko@async.com.br> backported to 2.18 by Rob Siklos <rsiklos@adexa.com>; r=vladd,kiko, a=justdave.
-rw-r--r--Bugzilla/Auth/CGI.pm10
1 files changed, 3 insertions, 7 deletions
diff --git a/Bugzilla/Auth/CGI.pm b/Bugzilla/Auth/CGI.pm
index 471e538e9..0a1a331f1 100644
--- a/Bugzilla/Auth/CGI.pm
+++ b/Bugzilla/Auth/CGI.pm
@@ -167,13 +167,7 @@ sub login {
# The account may be disabled
if ($authres == AUTH_DISABLED) {
- # Clear the cookie
-
- $cgi->send_cookie(-name => 'Bugzilla_login',
- -expires => "Tue, 15-Sep-1998 21:49:00 GMT");
- $cgi->send_cookie(-name => 'Bugzilla_logincookie',
- -expires => "Tue, 15-Sep-1998 21:49:00 GMT");
-
+ clear_browser_cookies();
# and throw a user error
ThrowUserError("account_disabled",
{'disabled_reason' => $extra});
@@ -222,8 +216,10 @@ sub logout {
sub clear_browser_cookies {
my $cgi = Bugzilla->cgi;
$cgi->send_cookie(-name => "Bugzilla_login",
+ -value => "",
-expires => "Tue, 15-Sep-1998 21:49:00 GMT");
$cgi->send_cookie(-name => "Bugzilla_logincookie",
+ -value => "",
-expires => "Tue, 15-Sep-1998 21:49:00 GMT");
}